Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to DataFrames Tutorial in index.md #1994

Merged
merged 4 commits into from
Nov 7, 2019

Conversation

dmolina
Copy link
Contributor

@dmolina dmolina commented Oct 27, 2019

I think that the website https://github.com/bkamins/Julia-DataFrames-Tutorial/ is a very useful resource, and it could be good to mention it in the documentation.

I think that the website [https://github.com/bkamins/Julia-DataFrames-Tutorial/](https://github.com/bkamins/Julia-DataFrames-Tutorial/) is a very useful resource, and it could be good to mention it in the documentation.
@nalimilan
Copy link
Member

Well since the author is the same as this package, we should probably move content to here when applicable. @bkamins?

@bkamins
Copy link
Member

bkamins commented Nov 2, 2019

@nalimilan - do you mean to migrate the whole of https://github.com/bkamins/Julia-DataFrames-Tutorial to DataFrames.jl manual?
It is doable without a problem (and I am OK with this and could do the changes).
The reason I was hesitant to do this (and kept them separate) is that https://github.com/bkamins/Julia-DataFrames-Tutorial is dependence-heavy (and I think it should as its objective is to show the ecosystem around DataFrames.jl). What do you think would be the best approach?

@nalimilan
Copy link
Member

I don't know, IIRC we discussed moving some parts to the DataFrames manual. I agree that the manual shouldn't require installing too many dependencies, so maybe it makes sense to point to the broader tutorial from the manual.

@@ -6,6 +6,8 @@ This resource aims to teach you everything you need
to know to get up and running with tabular data manipulation using the DataFrames.jl package
and the Julia language.

This documentation is always updated. There is available also a [DataFrames Tutorial in NoteBooks](https://github.com/bkamins/Julia-DataFrames-Tutorial/). That tutorial is not guarantee that be completely updated, but it is a good complementary resource to learn about DataFrames usage.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe don't insist on the risk of the tutorial being out of date, given that it's maintained by @bkamins. But mentioning that the tutorial illustrates other packages would make sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I have removed the mention to the risk of being out of date, and add that "it illustrates its usage in conjunction with other packages.".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, @bkamins I was referring only to make more accesible the Tutorial, I understand the aim of avoid the additional dependences. Only I think that the Tutorial is a great learning material, and it has a lot of sense mention it in the Documentation.

@bkamins
Copy link
Member

bkamins commented Nov 3, 2019

@dmolina - thank you! I think this is good to merge one @nalimilan checks it :). I will try to update the core documentation after v0.20 is released.

docs/src/index.md Outdated Show resolved Hide resolved
Small doc changes suggested mentioning the Tutorial in the doc.

Co-Authored-By: Bogumił Kamiński <bkamins@sgh.waw.pl>
@nalimilan nalimilan merged commit 6e287a1 into JuliaData:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants