Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate stackdf and meltdf #2031

Merged
merged 9 commits into from
Dec 6, 2019
Merged

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Dec 2, 2019

Fixes #1736. It does not have to go into v0.20 if some problems are found.

@bkamins bkamins added this to the 1.0 milestone Dec 2, 2019
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

src/abstractdataframe/reshape.jl Outdated Show resolved Hide resolved
src/abstractdataframe/reshape.jl Outdated Show resolved Hide resolved
src/abstractdataframe/reshape.jl Outdated Show resolved Hide resolved
src/abstractdataframe/reshape.jl Outdated Show resolved Hide resolved
@bkamins
Copy link
Member Author

bkamins commented Dec 4, 2019

OK - all should be fixed. I just used _ in front of internal functions _stackview and _meltview.

@bkamins
Copy link
Member Author

bkamins commented Dec 4, 2019

Only coverage fails here.

@bkamins
Copy link
Member Author

bkamins commented Dec 5, 2019

I will add deprecation of melt and meltdf in this PR as it duplicates stack and stackdf and we do not need both since we have Not for indexing. I will let you know when this is implemented.

@nalimilan
Copy link
Member

Maybe merge this now and file another PR as this one seems to be ready.

@bkamins
Copy link
Member Author

bkamins commented Dec 5, 2019

Thank you for having a look at this.

I had to clean up this PR anyway (I have left some references to stackdf in the docs - sorry for this) so I also deprecated melt. This is a rather simple fix, as it is either adding Not to an argument or changing argument order (you can see the changes in deprecated.jl).

@bkamins
Copy link
Member Author

bkamins commented Dec 5, 2019

This should be good to have a look at. I also wanted to have it in one shot as previously we changed methods that are removed entirely now.

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some doc fixes.

docs/src/lib/types.md Outdated Show resolved Hide resolved
docs/src/man/reshaping_and_pivoting.md Outdated Show resolved Hide resolved
docs/src/man/reshaping_and_pivoting.md Outdated Show resolved Hide resolved
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins
Copy link
Member Author

bkamins commented Dec 5, 2019

Incorporated all changes. Thank you for reviewing this.

@nalimilan nalimilan merged commit 6237a2b into JuliaData:master Dec 6, 2019
@bkamins bkamins deleted the deprecate_stackdf branch December 6, 2019 15:52
@bkamins
Copy link
Member Author

bkamins commented Dec 6, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a better API for stackdf and meltdf
2 participants