-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate stackdf and meltdf #2031
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
OK - all should be fixed. I just used |
Only coverage fails here. |
I will add deprecation of |
Maybe merge this now and file another PR as this one seems to be ready. |
Thank you for having a look at this. I had to clean up this PR anyway (I have left some references to |
This should be good to have a look at. I also wanted to have it in one shot as previously we changed methods that are removed entirely now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with some doc fixes.
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
Incorporated all changes. Thank you for reviewing this. |
Thank you! |
Fixes #1736. It does not have to go into v0.20 if some problems are found.