-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] deprecate names=true in eachcol #2120
Conversation
I decided to redesign
Given that probably |
There was a discussion the other day on slack that mentioned a convention of adding |
We now use a label |
08032de
to
e1707d2
Compare
@nalimilan the PR is good to have a look at. the ❌ is due to coveralls only. |
Co-Authored-By: Milan Bouchet-Valat <nalimilan@club.fr>
❌ is due to coverage |
The failing build on nightly is due to JuliaLang/julia#34889 so I will merge this. |
I just made a PR with a fix for JuliaLang/#34889, sorry about that. |
@pablosanjose - thank you for such a quick fix. |
Incidentally, use the faster `reduce(hcat, ...)` form.
Fixes #2090.
In the next move we will drop V parameter of
DataFrameColumns
.Making this PR revealed that
names=true
is in practice almost never used (at least internally), so this change - while big - should not be that problematic.