Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecation in append #2176

Merged
merged 2 commits into from
Apr 8, 2020
Merged

fix deprecation in append #2176

merged 2 commits into from
Apr 8, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Apr 6, 2020

correct use of eachcol in append!

@bkamins bkamins added the non-breaking The proposed change is not breaking label Apr 6, 2020
@bkamins bkamins added this to the 1.0 milestone Apr 6, 2020
@bkamins
Copy link
Member Author

bkamins commented Apr 8, 2020

@nalimilan I merged this PR with master as it is very simple so it is a good place to check if all works correctly everywhere after merging the "big" PRs.

@bkamins bkamins merged commit 08b01d3 into JuliaData:master Apr 8, 2020
@bkamins bkamins deleted the fix_depracation_in_append branch April 8, 2020 14:15
@bkamins
Copy link
Member Author

bkamins commented Apr 8, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
non-breaking The proposed change is not breaking
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bkamins @nalimilan