Make ByRow subtype Function #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Makes sense. Is it rebased against master (I have just merged #2199). If not can you please rebase? |
|
If we go for it also remove line |
|
done |
bkamins
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
Looks good. Thank you. @nalimilan - can you also have a quick look at this please?
@oxinabox - there is also one more Union to clean-up here: https://github.com/JuliaData/DataFrames.jl/blob/master/src/groupeddataframe/splitapplycombine.jl#L1096
nalimilan
reviewed
Apr 28, 2020
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ByRowis a function wrapper.Its callable, so it works like a function.
As such it is not unreasonable to for it to subtype
FunctionWhich means it is also covered by
Base.Callable.Which means we can simplify some of the more complex type constraints.
(I noticed this because these get more complex in #2199 )
In general I think if something is callable and doesn't already have a supertype, it is a fairly good idea to make it subtype
Function.(i would be in general a fan of dropping the constraints here entirely, but that would require closer looking at the code to see if it would cause any change in dispatch)