Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md with JuliaAcademy reference #2294

Merged
merged 3 commits into from
Aug 16, 2020

Conversation

logankilpatrick
Copy link
Contributor

Add a reference to JuliaAcademy

Add a reference to JuliaAcademy
@bkamins bkamins added backport non-breaking The proposed change is not breaking doc and removed backport labels Jun 17, 2020
@bkamins bkamins added this to the 1.0 milestone Jun 17, 2020
@bkamins
Copy link
Member

bkamins commented Jun 17, 2020

Let us just wait for @nalimilan to have a look.

@bkamins bkamins requested a review from nalimilan June 23, 2020 17:15
@nalimilan
Copy link
Member

Why not, but maybe we should add a few more references (notably @bkamins's tutorials) in the manual too?

@bkamins
Copy link
Member

bkamins commented Jun 23, 2020

I am OK with adding it as I plan to support it in long term. @logankilpatrick - if you are also OK with adding it then this is the link to the tutorial: https://github.com/bkamins/Julia-DataFrames-Tutorial/. Thank you!

@bkamins
Copy link
Member

bkamins commented Jul 30, 2020

@logankilpatrick - how do you see this proposal?

@logankilpatrick
Copy link
Contributor Author

What do you need on my end?

@bkamins
Copy link
Member

bkamins commented Jul 30, 2020

It is your PR, so I assumed that you would decide what you prefer and propose a final wording (either leave things as is or incorporate the other link)

README.md Outdated Show resolved Hide resolved
@bkamins
Copy link
Member

bkamins commented Aug 13, 2020

@nalimilan - is wording ok after the update I have just made?

README.md Outdated Show resolved Hide resolved
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins bkamins merged commit d2135cb into JuliaData:master Aug 16, 2020
@bkamins
Copy link
Member

bkamins commented Aug 16, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport doc non-breaking The proposed change is not breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants