Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rownumber #2356

Merged
merged 7 commits into from
Aug 17, 2020
Merged

add rownumber #2356

merged 7 commits into from
Aug 17, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Aug 7, 2020

Fixes #2325

I have also written a docstring that should explain the differences with parentindices

@bkamins bkamins added feature non-breaking The proposed change is not breaking labels Aug 7, 2020
@bkamins bkamins added this to the 1.0 milestone Aug 7, 2020
@bkamins bkamins mentioned this pull request Aug 7, 2020
Closed
nalimilan
nalimilan reviewed Aug 8, 2020
View reviewed changes
src/dataframerow/dataframerow.jl Outdated Show resolved Hide resolved
src/dataframerow/dataframerow.jl Outdated Show resolved Hide resolved
src/dataframerow/dataframerow.jl Show resolved Hide resolved
docs/src/lib/functions.md Outdated Show resolved Hide resolved
docs/src/lib/functions.md Outdated Show resolved Hide resolved
bkamins and others added 4 commits August 9, 2020 00:33
@bkamins @nalimilan
Apply suggestions from code review
5d38ebc 
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins
move rownumber to summary information
fe25067
@bkamins @nalimilan
Update src/dataframerow/dataframerow.jl
45750cb 
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins
add improved comments in the code
e6b2686
nalimilan
nalimilan approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after fixing the typo.

src/dataframerow/dataframerow.jl Outdated Show resolved Hide resolved
src/dataframerow/dataframerow.jl Outdated Show resolved Hide resolved
bkamins and others added 2 commits August 16, 2020 17:11
@bkamins @nalimilan
Apply suggestions from code review
c8b035a 
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins
remove ref from parentindices
dc445b4
@bkamins bkamins merged commit 5711ff1 into JuliaData:master Aug 17, 2020
@bkamins bkamins deleted the add_rownumber branch August 17, 2020 17:45
@bkamins
Copy link
Member Author

bkamins commented Aug 17, 2020

Thank you!

@JuliaRegistrator JuliaRegistrator mentioned this pull request Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
feature non-breaking The proposed change is not breaking
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

public API for accessing row number of DataFrameRow
2 participants
@bkamins @nalimilan