Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change kwarg rename to renamecols in joins #2398

Merged
merged 2 commits into from
Aug 31, 2020
Merged

change kwarg rename to renamecols in joins #2398

merged 2 commits into from
Aug 31, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Aug 30, 2020

This will make the kwarg naming conventions more consistent in DataFrames.jl (with reshaping and transformations)

@bkamins bkamins added the non-breaking The proposed change is not breaking label Aug 30, 2020
@bkamins bkamins added this to the 1.0 milestone Aug 30, 2020
@bkamins
Copy link
Member Author

bkamins commented Aug 30, 2020

This is non-breaking as the feature was not released yet.

@bkamins bkamins merged commit 60891d6 into JuliaData:master Aug 31, 2020
@bkamins bkamins deleted the join_renamecols branch August 31, 2020 09:08
@bkamins
Copy link
Member Author

bkamins commented Aug 31, 2020

Thank you!

@JuliaRegistrator JuliaRegistrator mentioned this pull request Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
non-breaking The proposed change is not breaking
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bkamins @nalimilan