Remove mutating examples for adding new columns #2434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rename` function in pandas creates a copy and so it would more appropriate to provide the equivalent DataFrames.jl example without any mutation as well.
|
Agreed - can you then just add another line where the two removed Julia codes would stay and in pandas you would show how to add a column to an existing data frame (without copying)? Thank you! |
|
Looks like 3 examples in that table have mutating versions. In pandas: df['z1'] = df['z'] + 1
df.rename(columns = {'x': 'x_new'}, inplace = True)
df.sort_values(by = 'x', inplace = True)How about we add a new table in the same section for these? |
|
OK - then we have a clearly separated "mutating" part. |
|
bkamins
reviewed
Sep 20, 2020
bkamins
approved these changes
Sep 22, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
renamefunction in pandas creates a copy and so it would more appropriate to provide the equivalent DataFrames.jl example without any mutation as well. Previous discussions at #2378 (comment)