Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix display problem with Turing.jl #2583

Merged
merged 1 commit into from
Dec 15, 2020
Merged

fix display problem with Turing.jl #2583

merged 1 commit into from
Dec 15, 2020

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Dec 15, 2020

Fixes #2582

@bkamins bkamins added this to the 1.0 milestone Dec 15, 2020
@bkamins bkamins mentioned this pull request Dec 15, 2020
Closed
@bkamins bkamins requested a review from ronisbr December 15, 2020 12:17
@ronisbr
Copy link
Member

ronisbr commented Dec 15, 2020

Hi @bkamins ,

Yes, it solves here too, but I have no idea why the type of maximum_columns_ width changes when these packages are loaded. Here, with only using DataFrames, it works perfectly.

@bkamins
Copy link
Member Author

bkamins commented Dec 15, 2020

I have no idea why the type of maximum_columns_width changes when these packages are loaded.

Probably Turing.jl adds some methods that invalidate type inference in the comprehension.

@bkamins bkamins merged commit 6d13479 into master Dec 15, 2020
@bkamins bkamins deleted the fix_display branch December 15, 2020 16:26
bkamins added a commit that referenced this pull request Dec 15, 2020
@bkamins
fix display problem with Turing.jl (#2583)
bcb9b7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronisbr ronisbr ronisbr approved these changes

Assignees
No one assigned
Labels
backport bug display priority
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

Error when showing dataframe in terminal
2 participants
@bkamins @ronisbr