Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for getproperty broadcasting #2655

Merged
merged 10 commits into from
Mar 25, 2021
Merged

add support for getproperty broadcasting #2655

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
50623ac
add support for getproperty broadcasting
bkamins Mar 12, 2021
79eefb2
improve the message
bkamins Mar 12, 2021
6ac1a09
update docs and tests
bkamins Mar 12, 2021
0fe53a4
change implementation
bkamins Mar 14, 2021
6e6540f
use the agreed rules
bkamins Mar 22, 2021
aa3ae55
more tests
bkamins Mar 22, 2021
d58802a
Merge branch 'main' into bk/dotgetproperty
bkamins Mar 22, 2021
f618b97
fix test
bkamins Mar 22, 2021
b3d1de3
Merge remote-tracking branch 'upstream/bk/dotgetproperty' into bk/dot…
bkamins Mar 22, 2021
170a97f
Apply suggestions from code review
bkamins Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/other/broadcasting.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,15 @@ end
Base.dotview(df::SubDataFrame, ::typeof(!), idxs) =
throw(ArgumentError("broadcasting with ! row selector is not allowed for SubDataFrame"))


if isdefined(Base, :dotgetproperty)
Base.dotgetproperty(df::DataFrame, col::SymbolOrString) =
LazyNewColDataFrame(df, Symbol(col))
Base.dotgetproperty(df::SubDataFrame, col::SymbolOrString) =
throw(ArgumentError("broadcasting getproperty is not allowed for SubDataFrame since " *
"Julia 1.7. use `df[:, $col] .= ... instead"))
end

function Base.copyto!(lazydf::LazyNewColDataFrame, bc::Base.Broadcast.Broadcasted{T}) where T
if bc isa Base.Broadcast.Broadcasted{<:Base.Broadcast.AbstractArrayStyle{0}}
bc_tmp = Base.Broadcast.Broadcasted{T}(bc.f, bc.args, ())
Expand Down