Bk/clean exports #2720
Merged
Bk/clean exports #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkamins
commented
Apr 15, 2021
bkamins
commented
Apr 15, 2021
nalimilan
reviewed
Apr 15, 2021
src/other/precompile.jl
Outdated
Comment on lines
1582
to
1585
| combine(groupby(DataFrame(v1=Int[]), :v1), identity, :v1 => sum) | ||
| innerjoin(DataFrame(v1=Int[]), DataFrame(v1=Int[]), on=:v1) | ||
| outerjoin(DataFrame(v1=Int[]), DataFrame(v1=Int[]), on=:v1) | ||
| end |
There was a problem hiding this comment.
If you do this, maybe also include a String and a PooledArray{String} column? Could also use e.g. :v1 => identity to cover the fallback.
There was a problem hiding this comment.
I went for an almost full sweep then.
bkamins
commented
Apr 15, 2021
nalimilan
approved these changes
Apr 15, 2021
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.