Synchronize ByRow and Tables.subset with Tables.jl 1.8 #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
reviewed
Sep 17, 2022
bkamins
commented
Sep 17, 2022
|
@nalimilan - could you please review this. Due to changes in Tables.jl 1.8 tests in DataFrames.jl will fail in all other PRs, so this PR needs to be merged first and next all other PRs must be updated against new |
nalimilan
reviewed
Sep 17, 2022
src/other/tables.jl
Outdated
| @@ -103,3 +103,12 @@ IteratorInterfaceExtensions.getiterator(df::AbstractDataFrame) = | |||
| Tables.datavaluerows(Tables.columntable(df)) | |||
| IteratorInterfaceExtensions.isiterable(x::AbstractDataFrame) = true | |||
| TableTraits.isiterabletable(x::AbstractDataFrame) = true | |||
|
|
|||
| function Tables.subset(df::AbstractDataFrame, inds; view::Union{Bool, Nothing}=nothing) | |||
There was a problem hiding this comment.
Should we use @inline to ensure the return type is inferred?
There was a problem hiding this comment.
added. It should not be a problem - the function is small (on newer Julia constant propagation also should be applied without inlining AFAICT, x-ref: JuliaLang/julia#43852).
There was a problem hiding this comment.
I added @inferred where applicable
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
bkamins
commented
Sep 17, 2022
nalimilan
approved these changes
Sep 17, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3127