Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ShiftedArrays 2.x support #3165

Merged
merged 2 commits into from
Sep 22, 2022
Merged

add ShiftedArrays 2.x support #3165

merged 2 commits into from
Sep 22, 2022

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Sep 19, 2022

Update tests to take into account the fact that lag is no longer exported.

@bkamins bkamins added the ecosystem Issues in DataFrames.jl ecosystem label Sep 19, 2022
@bkamins bkamins added this to the 1.4 milestone Sep 19, 2022
@bkamins
Copy link
Member Author

bkamins commented Sep 22, 2022

@nalimilan - this should be quick to review.

@bkamins bkamins merged commit f17f2c7 into main Sep 22, 2022
@bkamins bkamins deleted the bk/shiftedarrays branch September 22, 2022 19:03
@bkamins
Copy link
Member Author

bkamins commented Sep 22, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
ecosystem Issues in DataFrames.jl ecosystem
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@bkamins @nalimilan