Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve metadata documentation #3169

Merged
merged 6 commits into from
Sep 23, 2022
Merged

Improve metadata documentation #3169

merged 6 commits into from
Sep 23, 2022

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Sep 20, 2022

Fixes #3168

@bkamins bkamins added the doc label Sep 20, 2022
@bkamins bkamins added this to the 1.4 milestone Sep 20, 2022
@bkamins bkamins changed the title Improve GroupedDataFrame metadata description Improve metadata documentation Sep 21, 2022
@bkamins
Copy link
Member Author

bkamins commented Sep 21, 2022

I have added an example how one should check if some key is present in metadata.

nalimilan
nalimilan reviewed Sep 22, 2022
View reviewed changes
docs/src/lib/metadata.md Outdated Show resolved Hide resolved
bkamins and others added 3 commits September 22, 2022 21:03
@bkamins @nalimilan
Update docs/src/lib/metadata.md
304a511 
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins
improve in description
7f0f700
@bkamins
improve wording
88b41c1
@bkamins
Copy link
Member Author

bkamins commented Sep 22, 2022

I have moved the in part as you suggested and re-written it a bit to better match the context.

nalimilan
nalimilan approved these changes Sep 22, 2022
View reviewed changes
docs/src/lib/metadata.md Outdated Show resolved Hide resolved
@bkamins @nalimilan
Update docs/src/lib/metadata.md
23b5f3d 
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins bkamins merged commit a45c104 into main Sep 23, 2022
@bkamins bkamins deleted the bk/metadata_docs branch September 23, 2022 11:51
@bkamins
Copy link
Member Author

bkamins commented Sep 23, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

Metadata: follow-up notes
2 participants
@bkamins @nalimilan