-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve printing of GroupedDataFrame in corner cases #3187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked the logic, but you know better...
LGTM! |
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@nalimilan - it is good that we fixed these OutOfMemory issues on 32 bit machines as now our tests catch bugs instead of constantly failing. @Jollywatt - if you are interested have a look at the last commit if you want to know how tests should be written so that they are correct on both 64 and 32 bit architectures. |
Thank you! |
Fixes #3186
Covers all corner cases of various relative sizes of groups and single group.