Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allunique and improve nonunique and describe #3232

Merged
merged 6 commits into from
Dec 2, 2022
Merged

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Nov 25, 2022

Fixes #3205

Requires adding:

@bkamins bkamins added this to the 1.5 milestone Nov 25, 2022
@bkamins
Copy link
Member Author

bkamins commented Nov 25, 2022

Potentially allunique could fail fast, and now it processes all rows, but I guess this should be fast enough in practice (as when doing this test we usually expect it to return true) and doing the faster version would require much more code.

@bkamins bkamins changed the title Add allunique Add allunique and improve nonunique and describe Nov 28, 2022
src/dataframe/dataframe.jl Outdated Show resolved Hide resolved
@bkamins bkamins merged commit 1b9d037 into main Dec 2, 2022
@bkamins bkamins deleted the bk/allunique branch December 2, 2022 17:46
@bkamins
Copy link
Member Author

bkamins commented Dec 2, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support allunique with column selectors?
2 participants