Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in subset[!] when handling no conditions case #3264

Merged
merged 3 commits into from
Jan 8, 2023
Merged

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jan 2, 2023

This PR fixes a situation when we can only detect that no conditions are passed after processing them. Example of wrong behavior (fixed by this PR):

julia>     df = DataFrame(a=1:2)
2×1 DataFrame
 Row │ a
     │ Int64
─────┼───────
   1 │     1
   2 │     2

julia> subset(df, Not(:a) .=> ByRow(Returns(true)))
ERROR: AssertionError: !(isempty(conditions))

@bkamins bkamins added the bug label Jan 2, 2023
@bkamins bkamins added this to the 1.5 milestone Jan 2, 2023
@bkamins bkamins requested a review from nalimilan January 2, 2023 22:59
@bkamins bkamins merged commit 227d8d4 into main Jan 8, 2023
@bkamins bkamins deleted the bk/fixsubset branch January 8, 2023 17:23
@bkamins
Copy link
Member Author

bkamins commented Jan 8, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants