Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve unstack error messages #3344

Merged
merged 3 commits into from
Jun 25, 2023
Merged

improve unstack error messages #3344

merged 3 commits into from
Jun 25, 2023

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jun 20, 2023

Fixes #3339

@bkamins bkamins added the non-breaking The proposed change is not breaking label Jun 20, 2023
@bkamins bkamins added this to the 1.6 milestone Jun 20, 2023
@bkamins bkamins requested a review from nalimilan June 20, 2023 12:42
nalimilan
nalimilan reviewed Jun 22, 2023
View reviewed changes
src/abstractdataframe/reshape.jl Outdated Show resolved Hide resolved
src/abstractdataframe/reshape.jl Show resolved Hide resolved
@bkamins @nalimilan
Apply suggestions from code review
d898e97 
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@bkamins bkamins merged commit c82fb62 into main Jun 25, 2023
@bkamins bkamins deleted the bk/improve_unstack_errors branch June 25, 2023 08:32
@bkamins
Copy link
Member Author

bkamins commented Jun 25, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
non-breaking The proposed change is not breaking
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

unstack error message for missing values
2 participants
@bkamins @nalimilan