improve error messages in joins #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalimilan
reviewed
Jun 29, 2023
src/join/composer.jl
Outdated
Comment on lines
103
to
104
| "Such value was found in column :$col_name in " * | ||
| (df_i == 1 ? "left" : "right") * " data frame.")) |
There was a problem hiding this comment.
I'd mention this before CategoricalArrays so that it's clear what "such value" refers to.
docs/src/man/joins.md
Outdated
| │ Int64? Int64 Int64 | ||
| ─────┼────────────────────── | ||
| 1 │ 1 1 1 | ||
| ``` | ||
|
|
||
| ## Support for `-0.0` and `NaN` in joins |
There was a problem hiding this comment.
We mention this already under the "Key value comparisons and floating point values" section. How about putting the example there?
There was a problem hiding this comment.
ah - right. I was looking for it, but missed. Moved.
nalimilan
approved these changes
Jun 29, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3345