Add vector of names method to rename docstring
#3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkamins
approved these changes
Jul 19, 2023
|
Thank you! |
|
Should I be concerned about the failed CI test? |
|
No - the failure is due to "out of memory" on 32-bit machine. You can check it by going into test details and looking at the logs (I did it). You can see that the problematic test is on 32-bit machine as it says it is "x86" in the test process name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was documented in
rename!but not inrename, so I copied the example over. I also changed two Symbols to Strings in the second example so they also match.This is a comparison of the two docstrings before my changes:
