Fix @spawn_or_run_task with interactive threads
#3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Julia ≥ 1.9 is started with `-tX,Y`, by default tasks use the pool of interactive threads instead of the default pool. Fix this by updating `spawn_or_run_task` to match the code used by `@spawn` in Julia master.
bkamins
reviewed
Oct 7, 2023
bkamins
reviewed
Oct 7, 2023
|
Do we also need to update |
|
And also maybe we should add to documentation that we spawn threads in |
|
What do you think about setting |
OK |
bkamins
reviewed
Oct 8, 2023
bkamins
approved these changes
Oct 9, 2023
|
Looks good. Do you think we should additionally ask someone more who knows threading internals for review? |
|
Given that I just copied |
|
OK - so I think it is safe to merge this once you are ready :). |
bkamins
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Julia ≥ 1.9 is started with
-tX,Y, by default tasks use the pool of interactive threads instead of the default pool. Fix this by updatingspawn_or_run_taskto match the code used by@spawnin Julia master.Fixes #3383.