Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change big to BigInt calls #3419

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Change big to BigInt calls #3419

merged 2 commits into from
Jan 25, 2024

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Jan 19, 2024

Fixes #3418

@bkamins bkamins added the bug label Jan 19, 2024
@bkamins bkamins added this to the 1.7 milestone Jan 19, 2024
@bkamins
Copy link
Member Author

bkamins commented Jan 19, 2024

In all places we previously used big we actually required integer, so I propose to change to BigInt.

@bkamins bkamins merged commit 1683da5 into main Jan 25, 2024
6 of 7 checks passed
@bkamins bkamins deleted the bk/fix_bigint branch January 25, 2024 18:24
@bkamins
Copy link
Member Author

bkamins commented Jan 25, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quinnj quinnj quinnj approved these changes

@nalimilan nalimilan nalimilan approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

unique fails with column-type FixedDecimal
3 participants
@bkamins @nalimilan @quinnj