-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of Base internals (permute!!) #87
Conversation
I would just remove them. @nalimilan, @quinnj - what do you think? |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 87.97% 89.55% +1.57%
==========================================
Files 1 1
Lines 341 335 -6
==========================================
Hits 300 300
+ Misses 41 35 -6
☔ View full report in Codecov by Sentry. |
If they are removed from Base I agree we can just drop them. |
Thanks. Let's just wait for the decision in Julia then. |
I was holding off on merging the Base PR until after this to avoid transient breakage. If you are not willing to delete these methods until the Base PR merges, then we can revert this PR to 94beed6 which should be pretty uncontroversial. FWIW, I am not aware of any packages that call the methods this PR removes. |
OK, I thought that the PR was still being discussed in Julia. If all that's blocking it is PRs in packages let's merge this. |
bump |
@LilithHafner - do you need a release. If yes - can you please bump the version of the package to 1.4.3 in this PR and then I can merge it and make a release. |
Yes, I do need a release, thank you. |
permute!!
andinvpermute!!
are internal functions of Base and are likely to be removed soon. This PR makes it so that if they are gone, PooledArrays will still compile.AFAICT, nobody uses these methods anyway, so deleting them would work too, but this approach has a more minimal impact.