Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shorter name for InlineString[X] #85

Closed
bkamins opened this issue Sep 8, 2021 · 2 comments · Fixed by #87
Closed

shorter name for InlineString[X] #85

bkamins opened this issue Sep 8, 2021 · 2 comments · Fixed by #87

Comments

@bkamins
Copy link
Member

bkamins commented Sep 8, 2021

InlineString[X] is a long name. It does not display very nicely.

My proposal would be:

  • rename InlineString1 to String1
  • make InlineString1 an alias pointing to String1 (so that the change is not breaking)

CC @nalimilan @quinnj
This was referenced Sep 8, 2021
Merged
Closed
@nalimilan
Copy link
Member

To add some arguments: the printing of InlineString[X] in the header of data frame columns is quite bad as the name is longer than the contents of the column (which are short strings by definition). String[X] would be shorter, and I like the parallel with Int[X] and such.

@quinnj
Copy link
Member

quinnj commented Sep 8, 2021

Yeah, that all sounds good to me. Someone mind making a PR?

@bkamins bkamins mentioned this issue Sep 8, 2021
Merged
@quinnj quinnj closed this as completed in #87 Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add String[X] types JuliaData/WeakRefStrings.jl
3 participants
@nalimilan @quinnj @bkamins