Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add String[X] types #87

Merged
merged 2 commits into from
Sep 8, 2021
Merged

add String[X] types #87

merged 2 commits into from
Sep 8, 2021

Conversation

bkamins
Copy link
Member

@bkamins bkamins commented Sep 8, 2021

Fixes #85

CC @quinnj

@bkamins bkamins requested a review from quinnj September 8, 2021 18:54
@bkamins
Copy link
Member Author

bkamins commented Sep 8, 2021

and @nalimilan

README.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #87 (6891905) into main (31b603a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   80.35%   80.35%           
=======================================
  Files           3        3           
  Lines         962      962           
=======================================
  Hits          773      773           
  Misses        189      189           
Impacted Files Coverage Δ
src/inlinestrings.jl 88.76% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31b603a...6891905. Read the comment docs.

Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quinnj quinnj merged commit 14415d1 into main Sep 8, 2021
@quinnj quinnj deleted the bk/stringx branch September 8, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shorter name for InlineString[X]
2 participants