Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure string(::PosLenString) returns String #93

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Ensure string(::PosLenString) returns String #93

merged 1 commit into from
Oct 2, 2021

Conversation

quinnj
Copy link
Member

@quinnj quinnj commented Oct 2, 2021

Fixes the type instability issue mentioned in
JuliaStrings/InlineStrings.jl#2.

@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #93 (de03945) into main (786fddd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   76.39%   76.39%           
=======================================
  Files           2        2           
  Lines         627      627           
=======================================
  Hits          479      479           
  Misses        148      148           
Impacted Files Coverage Δ
src/poslenstrings.jl 74.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786fddd...de03945. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant