Fix the tests and add reaction on window resizing and fix selectlevel #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not yet working correctly, because they have different number of layers and I would have to make the test case more streamlined.
This will change the selected resolution when changing the axis size for example when changing the window size. Closes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
===========================================
- Coverage 77.27% 66.03% -11.24%
===========================================
Files 1 3 +2
Lines 110 265 +155
===========================================
+ Hits 85 175 +90
- Misses 25 90 +65 ☔ View full report in Codecov by Sentry. |
|
The CI failure on Windows seems to be a GDAL_jll build issue JuliaPackaging/Yggdrasil#8781 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix all tests and adds an on interaction to react on the change of the axis size.
This also fixes selectlevel to always select the right amount of data.
Closes #41