Switch to extensions instead of requires for datasets #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves everything from using Requires to the new extensions setup.
This ensures, that the tests for different backends are independent.
We decided to only support julia versions larger than 1.9
When we restrict the Julia version to 1.9 we should also stop testing on 1.6
This seems to be not maintained anymore with the last commit three years ago
|
@meggart this should be good to go now. I removed AxisIndices because the last commit is three years ago and it had some dependency problems. The tests go through locally on 1.11 rc2 and on CI on nightly. |
|
This is breaking because it removes the AxisIndices functionality. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 51.75% 50.00% -1.76%
==========================================
Files 13 12 -1
Lines 342 344 +2
==========================================
- Hits 177 172 -5
- Misses 165 172 +7 ☔ View full report in Codecov by Sentry. |
|
Great, thanks a lot for preparing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #18.