Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #62

Merged
merged 2 commits into from
May 21, 2021
Merged

Fix issues #62

merged 2 commits into from
May 21, 2021

Conversation

meggart
Copy link
Member

@meggart meggart commented May 11, 2021

This should fix #61 by showing a Progress meter of unknown length if length is unknown and #58 by throwing a warning when no common axes are found in 2 cubes

@meggart
Copy link
Member Author

meggart commented May 11, 2021

And adds a hash function for CubeAxis, fixing #60

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #62 (357a474) into master (4de682d) will decrease coverage by 0.15%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   55.56%   55.41%   -0.16%     
==========================================
  Files          13       13              
  Lines        1544     1550       +6     
==========================================
+ Hits          858      859       +1     
- Misses        686      691       +5     
Impacted Files Coverage Δ
src/DAT/dciterators.jl 0.00% <0.00%> (ø)
src/DAT/tablestats.jl 0.00% <0.00%> (ø)
src/Cubes/Axes.jl 60.66% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de682d...357a474. Read the comment docs.

@coveralls
Copy link

coveralls commented May 11, 2021

Pull Request Test Coverage Report for Build 832207247

  • 0 of 7 (0.0%) changed or added relevant lines in 2 files are covered.
  • 24 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 55.297%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DAT/dciterators.jl 0 2 0.0%
src/DAT/tablestats.jl 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/Cubes/Axes.jl 24 60.14%
Totals Coverage Status
Change from base Build 813326560: -0.3%
Covered Lines: 856
Relevant Lines: 1548

💛 - Coveralls

@meggart meggart merged commit d2774e5 into master May 21, 2021
@felixcremer felixcremer added the test needed We should add a test to catch this in the future. label Aug 18, 2021
@meggart meggart deleted the unknowntablesize branch February 28, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test needed We should add a test to catch this in the future.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cubefittable fails on TableOperations.Filter
3 participants