Introduce executemultiple for returning multiple resultsets from
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
single query Lots of databases (and even the ODBC spec) support returning multiple resultsets from a single query execution call (usually the individual sql queries must be separated by semi-colons, but stored procedures can also return multiple resultsets). This formalizes the idea by introducing `DBInterface.executemultiple`, which looks and acts exactly like `DBInterface.execute` (takes `conn` arg, query string, params, etc.), except instead of returning a single `Cursor`, it returns an iterator of `Cursor`s. I like that this doesn't affect/change `execute` at all, and is strictly additive in functionality for the interface overall.
quinnj
added a commit
to JuliaDatabases/MySQL.jl
that referenced
this pull request
May 3, 2020
This allows returning multiple resultsets from a single query call; this requires setting `multi_statements` to `true` by default, but I couldn't think of any downside to doing this (vs. the alternative in which a user finds the function, tries it and immediately fails and has to restart their connection by setting the flag). Prepared statements don't support multiple resultsets, and an error is thrown appropriately (from mysql itself). This PR requires JuliaDatabases/DBInterface.jl#26 to be merged and tagged first.
quinnj
added a commit
to JuliaDatabases/MySQL.jl
that referenced
this pull request
May 5, 2020
This allows returning multiple resultsets from a single query call; this requires setting `multi_statements` to `true` by default, but I couldn't think of any downside to doing this (vs. the alternative in which a user finds the function, tries it and immediately fails and has to restart their connection by setting the flag). Prepared statements don't support multiple resultsets, and an error is thrown appropriately (from mysql itself). This PR requires JuliaDatabases/DBInterface.jl#26 to be merged and tagged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
single query
Lots of databases (and even the ODBC spec) support returning multiple
resultsets from a single query execution call (usually the individual
sql queries must be separated by semi-colons, but stored procedures can
also return multiple resultsets). This formalizes the idea by
introducing
DBInterface.executemultiple, which looks and acts exactlylike
DBInterface.execute(takesconnarg, query string, params,etc.), except instead of returning a single
Cursor, it returns aniterator of
Cursors. I like that this doesn't affect/changeexecuteat all, and is strictly additive in functionality for the interface
overall.