Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for DBInterface #274

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

TheCedarPrince
Copy link
Collaborator

This finishes @chris-b1's initial PR they had drafted in #271; it closes #271.

I am opening this new PR that rebases against master such that this feature can be merged after the other PR hasn't had any recent activity from the original creator. Credit and a huge thanks for the majority of this PR goes to @chris-b1 and @xitology for initial implementation help.

@iamed2 , this PR has been rebased against master and is ready to merge per your last comment. Are you comfortable merging this? If so, feel free to hit the merge button when ready! 💯

@iamed2
Copy link
Collaborator

iamed2 commented Jul 24, 2023

Happy to merge! Thanks for sticking with it.

@chris-b1
Copy link
Contributor

Thanks for picking this up @TheCedarPrince - I appreciate it!

@TheCedarPrince
Copy link
Collaborator Author

Awesome! @iamed2 -- feel free to merge! 💯 Of course, thank you for getting this started @chris-b1 !

@iamed2 iamed2 merged commit 2c0547d into JuliaDatabases:master Jul 25, 2023
12 of 14 checks passed
@TheCedarPrince
Copy link
Collaborator Author

Thank you all!!!! This is amazing!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants