Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to array changes in Julia base #596

Merged
merged 2 commits into from
Nov 28, 2023
Merged

adapt to array changes in Julia base #596

merged 2 commits into from
Nov 28, 2023

Conversation

simeonschaub
Copy link
Collaborator

JuliaLang/julia#51319 added and removed a lot of builtins. Adapt generate_builtins accordingly

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (7beca92) 86.54% compared to head (f06d82a) 82.56%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/builtins.jl 11.25% 71 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   86.54%   82.56%   -3.99%     
==========================================
  Files          12       12              
  Lines        2542     2437     -105     
==========================================
- Hits         2200     2012     -188     
- Misses        342      425      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simeonschaub
Copy link
Collaborator Author

CI is a bit of a 🗑️🔥 rn, so review with care 😀

bin/generate_builtins.jl Outdated Show resolved Hide resolved
Co-authored-by: Shuhei Kadowaki <40514306+aviatesk@users.noreply.github.com>
@simeonschaub simeonschaub merged commit 9d50726 into master Nov 28, 2023
3 of 17 checks passed
@simeonschaub simeonschaub deleted the sds/memory branch November 28, 2023 10:59
aviatesk added a commit that referenced this pull request Nov 28, 2023
aviatesk added a commit that referenced this pull request Nov 28, 2023
aviatesk added a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants