Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust to the :enter IR changes made in JuliaLang/julia#52300 #599

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

aviatesk
Copy link
Member

I don't expect this commit to fix the CI on 🔥, but since these changes are straightforward, we should be able to go ahead and merge this as is.

Copy link
Collaborator

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I don't expect this commit to fix the CI on 🔥, but since these
changes are straightforward, we should be able to go ahead and merge
this as is.
@aviatesk aviatesk force-pushed the avi/adjust-julia52300 branch from a6f2c4c to ac31b22 Compare November 28, 2023 11:30
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9d50726) 82.53% compared to head (ac31b22) 85.22%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/interpret.jl 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   82.53%   85.22%   +2.69%     
==========================================
  Files          12       12              
  Lines        2439     2586     +147     
==========================================
+ Hits         2013     2204     +191     
+ Misses        426      382      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aviatesk aviatesk merged commit ce20820 into master Nov 28, 2023
6 of 17 checks passed
@aviatesk aviatesk deleted the avi/adjust-julia52300 branch November 28, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants