No Differentiable Factorial (#458)

JuliaDiff · Jun 28, 2021 · bbb88f7 · bbb88f7 · mzgubic · Jun 28, 2021
1 parent 87458d0
commit bbb88f7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "ChainRules"
 uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
-version = "0.8.16"
+version = "0.8.17"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

diff --git a/src/rulesets/Base/nondiff.jl b/src/rulesets/Base/nondiff.jl
@@ -13,7 +13,6 @@
 @non_differentiable ==(::Any, ::Any)
 @non_differentiable ===(::Any, ::Any)
 
-
 @non_differentiable Bool(::Any)
 
 @non_differentiable accumulate(::Any, ::AbstractArray{Bool})
@@ -133,6 +132,8 @@ VERSION >= v"1.1" && @non_differentiable fieldtypes(T)
 @non_differentiable fieldname(T, ::Integer)
 @non_differentiable fieldnames(T)
 
+@non_differentiable factorial(n::Integer)
+
 @non_differentiable findall(::Union{Regex, AbstractString, Function}, ::AbstractString)
 @non_differentiable findall(::Function, ::AbstractArray)
 @non_differentiable findall(::AbstractArray)