Fix various type-instabilities #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxinabox
reviewed
Dec 15, 2020
oxinabox
reviewed
Dec 15, 2020
oxinabox
reviewed
Dec 15, 2020
oxinabox
reviewed
Dec 15, 2020
Comment on lines
+185
to
+189
| function _norm1_back(x, y, Δy) | ||
| ∂x = similar(x) | ||
| ∂x .= sign.(x) .* real(Δy) | ||
| return ∂x | ||
| end |
There was a problem hiding this comment.
It feels bad that we have to do this.
Should we open an issue on JuliaLang/julia about it?
There was a problem hiding this comment.
No, I think this is necessarily type-unstable, e.g.
julia> x = Diagonal([1.0, 2.0, 3.0]);
julia> x .* 0
3×3 Diagonal{Float64,Array{Float64,1}}:
0.0 ⋅ ⋅
⋅ 0.0 ⋅
⋅ ⋅ 0.0
julia> x .* 10
3×3 Diagonal{Float64,Array{Float64,1}}:
10.0 ⋅ ⋅
⋅ 20.0 ⋅
⋅ ⋅ 30.0
julia> x .* Inf
3×3 Array{Float64,2}:
Inf NaN NaN
NaN Inf NaN
NaN NaN Inf
julia> x .* NaN
3×3 Array{Float64,2}:
NaN NaN NaN
NaN NaN NaN
NaN NaN NaN
There was a problem hiding this comment.
Note that this breaks gradient(norm, [1,2,3]).
oxinabox
approved these changes
Dec 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
+ Coverage 97.62% 97.64% +0.01%
==========================================
Files 18 18
Lines 1011 1018 +7
==========================================
+ Hits 987 994 +7
Misses 24 24
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes most of the type-instabilities identified by JuliaDiff/ChainRulesTestUtils.jl#78, the remainder being documented in #328 and JuliaDiff/ChainRulesCore.jl#265 or for type-unstable primals. I'm not yet adding any new tests because that would be redundant with the above PR. Until it is merged, this PR just checks that our current functionality tests still pass.