Update rules for SpecialFunctions #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBH i don't care about them being tested properly. |
oxinabox
approved these changes
May 7, 2021
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
- Coverage 98.45% 88.86% -9.60%
==========================================
Files 23 23
Lines 1878 1428 -450
==========================================
- Hits 1849 1269 -580
- Misses 29 159 +130
Continue to review full report at Codecov.
|
|
Test failures with Julia nightly seem to be unrelated and exist on master as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the rules for SpecialFunctions, in the same way as JuliaMath/SpecialFunctions.jl#308.
I think it might be necessary to fix SpecialFunctions to an older version without ChainRulesCore dependency if we want the rules in ChainRules to be tested properly. However, this might cause problems with other test dependencies (older versions etc.), so maybe it should be done in a separate environment?