Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the rule overload generation stuff #356

Merged
merged 3 commits into from
Jun 1, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/IntegrationTest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ jobs:
os: [ubuntu-latest]
package:
- {user: JuliaDiff, repo: ChainRules.jl}
- {user: JuliaDiff, repo: ChainRulesOverloadGeneration.jl}
- {user: JuliaMath, repo: SpecialFunctions.jl}
- {user: invenia, repo: BlockDiagonals.jl}
- {user: invenia, repo: PDMatsExtras.jl}
Expand Down
5 changes: 1 addition & 4 deletions docs/make.jl
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,7 @@ makedocs(
"Deriving Array Rules" => "arrays.md",
"Debug Mode" => "debug_mode.md",
"Gradient Accumulation" => "gradient_accumulation.md",
"Usage in AD" => [
"Overview" => "autodiff/overview.md",
"Operator Overloading" => "autodiff/operator_overloading.md",
],
"Usage in AD" => "use_in_ad_system.md",
"Design" => [
"Changing the Primal" => "design/changing_the_primal.md",
"Many Differential Types" => "design/many_differentials.md",
Expand Down
8 changes: 0 additions & 8 deletions docs/src/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,8 @@ add!!
ChainRulesCore.is_inplaceable_destination
```

## Ruleset Loading
```@autodocs
Modules = [ChainRulesCore]
Pages = ["ruleset_loading.jl"]
Private = false
```

## Internal
```@docs
ChainRulesCore.AbstractTangent
ChainRulesCore.debug_mode
ChainRulesCore.clear_new_rule_hooks!
```
80 changes: 0 additions & 80 deletions docs/src/autodiff/operator_overloading.md

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ to avoid having to code all your own AD primitives / custom sensitives.

There are 3 main ways to access ChainRules rule sets in your AutoDiff system.

1. [Operation Overloading Generation](operator_overloading.html)
1. [Operator Overloading Generation](https://juliadiff.org/ChainRulesOverloadGeneration.jl/stable)
- Use [ChainRulesOverloadGeneration.jl](https://github.com/JuliaDiff/ChainRulesOverloadGeneration.jl/).
- This is primarily intended for operator overloading based AD systems which will generate overloads for primal functions based for their overloaded types based on the existence of an `rrule`/`frule`.
- A source code generation based AD can also use this by overloading their transform generating function directly so as not to recursively generate a transform but to just return the rule.
- This does not play nice with Revise.jl, adding or modifying rules in loaded files will not be reflected until a manual refresh, and deleting rules will not be reflected at all.
Expand Down
3 changes: 0 additions & 3 deletions src/ChainRulesCore.jl
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ using LinearAlgebra: LinearAlgebra
using SparseArrays: SparseVector, SparseMatrixCSC
using Compat: hasfield

export on_new_rule, refresh_rules # generation tools
export frule, rrule # core function
export @non_differentiable, @scalar_rule, @thunk, @not_implemented # definition helper macros
export canonicalize, extern, unthunk # differential operations
Expand All @@ -27,9 +26,7 @@ include("accumulation.jl")

include("rules.jl")
include("rule_definition_tools.jl")
include("ruleset_loading.jl")

include("deprecated.jl")
include("precompile.jl")

end # module
1 change: 0 additions & 1 deletion src/precompile.jl

This file was deleted.

142 changes: 0 additions & 142 deletions src/ruleset_loading.jl

This file was deleted.

91 changes: 0 additions & 91 deletions test/demos/forwarddiffzero.jl

This file was deleted.

Loading