make @non_differentiable use identical pullbacks when possible
#679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
May 30, 2024
|
The test failures are integration tests, with ChainRulesOverloadGeneration.jl and Diffractor.jl. The ChainRulesOverloadGeneration.jl test failures seem unrelated, while Diffractor.jl has lots of opaque closure-related failures, but these fail independently of this PR. So I think this is good for review. |
|
The change is now improved and the diff much smaller. |
devmotion
reviewed
May 31, 2024
src/rule_definition_tools.jl
Outdated
| function $(esc(propagator_name(primal_name, :pullback)))(@nospecialize(_)) | ||
| return $(tup_expr) | ||
| end | ||
| NonDiffPullback($(tup_expr)) |
There was a problem hiding this comment.
I guess even simpler would be
Suggested change
| NonDiffPullback($(tup_expr)) | |
| Returns($(tup_expr)) |
There was a problem hiding this comment.
That will change the method signature, though. Currently the pullback accepts a single argument, while Returns accepts any amount of arguments. Is that OK to change?
devmotion
approved these changes
May 31, 2024
devmotion
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #678