-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mistake in non-tuple output message #177
Conversation
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
- Coverage 87.45% 87.41% -0.05%
==========================================
Files 10 10
Lines 295 294 -1
==========================================
- Hits 258 257 -1
Misses 37 37
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM, just needs fixing the docs
Co-authored-by: Miha Zgubic <mzgubic@users.noreply.github.com>
Test Summary: | Pass Total | ||
test_frule: two2three on Float64,Float64 | 6 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Documenter (fix doctests)] reported by reviewdog 🐶
Test Summary: | Pass Total | |
test_frule: two2three on Float64,Float64 | 6 6 |
Test Summary: | Pass Total | ||
test_rrule: two2three on Float64,Float64 | 7 7 | ||
test_rrule: two2three on Float64,Float64 | 8 8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Documenter (fix doctests)] reported by reviewdog 🐶
Test Summary: | Pass Total | |
test_rrule: two2three on Float64,Float64 | 7 7 | |
test_rrule: two2three on Float64,Float64 | 8 8 |
Test Summary: | Pass Total | ||
test_scalar: relu at 0.5 | 9 9 | ||
test_scalar: relu at 0.5 | 10 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Documenter (fix doctests)] reported by reviewdog 🐶
Test Summary: | Pass Total | |
test_scalar: relu at 0.5 | 9 9 | |
test_scalar: relu at 0.5 | 10 10 |
Test Summary: | Pass Total | ||
test_scalar: relu at -0.5 | 9 9 | ||
test_scalar: relu at -0.5 | 10 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Documenter (fix doctests)] reported by reviewdog 🐶
Test Summary: | Pass Total | |
test_scalar: relu at -0.5 | 9 9 | |
test_scalar: relu at -0.5 | 10 10 |
the auto suggesting of fixes seems to be be doing a bad. |
∂s
was renamed toad_cotangents
, but we missed it in this error message.So I fixed that and I also changed it to use
test_msg
rather than erroring.added a test for this case, making sure it failed rather than erroring.
I also changed the length one after to not define a variable called
msg
since that was confusing as to which was meant.