Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mistake in non-tuple output message #177

Merged
merged 9 commits into from
Jun 16, 2021
Merged

fix mistake in non-tuple output message #177

merged 9 commits into from
Jun 16, 2021

Conversation

oxinabox
Copy link
Member

∂s was renamed to ad_cotangents, but we missed it in this error message.
So I fixed that and I also changed it to use test_msg rather than erroring.
added a test for this case, making sure it failed rather than erroring.

I also changed the length one after to not define a variable called msg since that was confusing as to which was meant.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #177 (68fc041) into master (e21bf34) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   87.45%   87.41%   -0.05%     
==========================================
  Files          10       10              
  Lines         295      294       -1     
==========================================
- Hits          258      257       -1     
  Misses         37       37              
Impacted Files Coverage Δ
src/testers.jl 93.69% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21bf34...68fc041. Read the comment docs.

Copy link
Member

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, just needs fixing the docs

src/testers.jl Outdated Show resolved Hide resolved
docs/Manifest.toml Show resolved Hide resolved
docs/Manifest.toml Show resolved Hide resolved
docs/Manifest.toml Show resolved Hide resolved
docs/Manifest.toml Outdated Show resolved Hide resolved
Comment on lines 62 to 63
Test Summary: | Pass Total
test_frule: two2three on Float64,Float64 | 6 6

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Documenter (fix doctests)] reported by reviewdog 🐶

Suggested change
Test Summary: | Pass Total
test_frule: two2three on Float64,Float64 | 6 6

Comment on lines 74 to +75
Test Summary: | Pass Total
test_rrule: two2three on Float64,Float64 | 7 7
test_rrule: two2three on Float64,Float64 | 8 8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Documenter (fix doctests)] reported by reviewdog 🐶

Suggested change
Test Summary: | Pass Total
test_rrule: two2three on Float64,Float64 | 7 7
test_rrule: two2three on Float64,Float64 | 8 8

Comment on lines 102 to +103
Test Summary: | Pass Total
test_scalar: relu at 0.5 | 9 9
test_scalar: relu at 0.5 | 10 10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Documenter (fix doctests)] reported by reviewdog 🐶

Suggested change
Test Summary: | Pass Total
test_scalar: relu at 0.5 | 9 9
test_scalar: relu at 0.5 | 10 10

Comment on lines 107 to +108
Test Summary: | Pass Total
test_scalar: relu at -0.5 | 9 9
test_scalar: relu at -0.5 | 10 10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Documenter (fix doctests)] reported by reviewdog 🐶

Suggested change
Test Summary: | Pass Total
test_scalar: relu at -0.5 | 9 9
test_scalar: relu at -0.5 | 10 10

@oxinabox
Copy link
Member Author

the auto suggesting of fixes seems to be be doing a bad.
I am tempted to leave it in and see if it comes up good after: it might be some how confused since I have messed with documenter so much.

@oxinabox oxinabox merged commit dffcfff into master Jun 16, 2021
@DilumAluthge DilumAluthge deleted the ox/typo branch August 18, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants