Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak Zero to vec #115

Merged
merged 4 commits into from
Nov 20, 2020
Merged

Tweak Zero to vec #115

merged 4 commits into from
Nov 20, 2020

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Nov 20, 2020 •
edited
Loading

to_vec for AbstractZeros was returning a non-empty vector, which is both unnecessary and potentially incorrect (AbstractZeros are structural, so if FiniteDifferences were to perturb an AbstractZero, bad things would presumably happen).

@willtebbutt willtebbutt changed the title Tweak Zero to vec Tweak Zero and Diagonal to vec Nov 20, 2020
@willtebbutt willtebbutt changed the title Tweak Zero and Diagonal to vec Tweak Zero to vec Nov 20, 2020
@willtebbutt willtebbutt mentioned this pull request Nov 20, 2020
Merged
mzgubic
mzgubic approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@mzgubic mzgubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder whether the test_to_vec function could be improved somehow?

@willtebbutt willtebbutt merged commit 673d6fa into master Nov 20, 2020
@willtebbutt willtebbutt deleted the wct/fix-Zero-tovec branch November 20, 2020 14:56
@sethaxen sethaxen mentioned this pull request Dec 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzgubic mzgubic mzgubic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willtebbutt @mzgubic