Vectorized decompression #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matbesancon
reviewed
Jun 29, 2019
|
can't we specialize for GPU and keep the looping default? |
|
Yes, this is just prototyping. I wrote this on a plane and pushed it so we wouldn't lose what the correct translation is, because it's pretty gnarly. I may finish it up later or if @pkj-m has a GPU and wants to try pushing the GPU algorithm until |
ChrisRackauckas
force-pushed
the
vectorized
branch
from
6f30078
to
a3b145b
Compare
matbesancon
reviewed
Jul 30, 2019
matbesancon
reviewed
Jul 30, 2019
matbesancon
reviewed
Jul 30, 2019
matbesancon
reviewed
Jul 30, 2019
add a comment to the very non-obvious vectorized code
Co-Authored-By: Mathieu Besançon <mathieu.besancon@gmail.com>
Co-Authored-By: Mathieu Besançon <mathieu.besancon@gmail.com>
ChrisRackauckas
force-pushed
the
vectorized
branch
from
fa62624
to
d7ce4ef
Compare
matbesancon
reviewed
Jul 30, 2019
| struct ContractionColor <: ColoringAlgorithm end | ||
| struct GreedyStar1Color <: ColoringAlgorithm end | ||
| struct GreedyStar2Color <: ColoringAlgorithm end | ||
| abstract type SparseDiffToolsColoringAlgorithm <: ArrayInterface.ColoringAlgorithm end |
There was a problem hiding this comment.
SparseDiffToolsColoringAlgorithm not a fan of the package name plugged into types, C-like. Couldn't we not-export ColoringAlgorithm, thus calling it with SparseDiffToolsColoringAlgorithm. Other solution would be to remove the abstract type all together and use ArrayInterface.ColoringAlgorithm directly
matbesancon
reviewed
Jul 30, 2019
Co-Authored-By: Mathieu Besançon <mathieu.besancon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is slower but potentially useful for GPUs: