-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pluto #121
Conversation
@Dsantra92 Great! I'll check this PR this weekend and see if there's anything I can do to quickly get this in. |
Sorry, it's a busy weekend, I'll manage to get some time for this PR ASAP |
@Dsantra92 I failed to manage some time doing this (busy work, busy life); really sorry about this! I didn't check it locally, but the overall changes look okay to me. I just sent you an write invitation to this package so if you're confident, you're free to merge this and add any wanted feature (and potential bug fixes 😆 ). |
This pr isn't complete yet. I will merge when it's completed. |
This is good to go as a beta feature. Example here. It will be complete with docs and some tests for edge cases ( I cannot add time for it this week). |
You make the decision |
as long as there's a commitment, it's all okay to me |
I think I can make the docs and basic tests work within the coming weeks. Let's merge this as a beta feature now. |
Julia v1.0 is not supported by PlutoStaticHTML, we should update the julia version bound of DemoCards.jl to julia v1.6. Not clear why windows test on latest julia are failing |
Thanks for the review @CarloLucibello, will get the changes done asap. |
Hi @CarloLucibello the changes you suggested to src/types/pluto.jl makes sense but I then the functions and doc style will differ from the exisiting markdown and julia files. Just wanted to make these things uniform across the different types. |
Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
ok, let's relax to AbstractString and merge and tag quickly then. |
There should be a minor version bump? |
No breaking changes, so bump to 0.4.10 |
I went to bump and release myself. Hope it's okay. |
Hi @johnnychen94, I did some work on the Pluto notebook. Sorry, it took so long. Currently, it supports rendering a pluto notebook using PlutoStaticHTML. I am concerned with adding a title and other badges to the rendered notebook.
However, parsing metadata won't be similar to Julia or markdown's. Pluto.jl has full control over a notebook's start and end content, so we might need to create special
parse
for Pluto that can parse metadata from the file allowing multiline regex matching. I need some advice as to whether I should go ahead with this approach.