Update Documenter compat for version 1.0 #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Those are some real breakages -- that regex stuff was always going to be a bit fragile. I'll see if I can fix it in a bit. |
frankier
force-pushed
the
compat-documenter1
branch
3 times, most recently
from
ca6f631 to
33cf079
Compare
Previously Documenter's HTML was postprocessed in order to point edit on GitHub links to the original source file as input to DemoCards.jl. This commit changes this so that the original source file is provided to Documenter.jl in the generated markdown files using the @meta: EditURL setting. This is less fragile to changes in Documenter.jl or e.g. different templates since it doesn't rely on using regex to modify the particular form of the HTML output by Documenter.jl.
frankier
force-pushed
the
compat-documenter1
branch
from
33cf079 to
a87b5f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.