Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Factor out Travis environment reading #1147

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Conversation

fredrikekre
Copy link
Member

Factor out Travis environment reading and deploy configuration to a separate small interface that others can use.

@fredrikekre fredrikekre changed the title Factor out Travis environment reading [NFC] Factor out Travis environment reading Oct 7, 2019
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I should have started with this instead 😆 But I only have the same comments as for #1144:

  • Rename DeployDocs.jl to deploydocs.jl
  • Could we have some unit tests for should_deploy?

Otherwise, this looks awesome!

@fredrikekre
Copy link
Member Author

Done, also added a changelog entry.

CHANGELOG.md Outdated Show resolved Hide resolved
to a separate small interface that others can use, fixes #1087.
@fredrikekre fredrikekre merged commit e56011b into master Oct 8, 2019
@fredrikekre fredrikekre deleted the fe/factor-travis branch October 8, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants