Builtin support for GitHub Actions #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, there was some bugs, but now it worked and deployed: https://github.com/fredrikekre/Literate.jl/runs/248626524 |
mortenpi
reviewed
Oct 7, 2019
There was a problem hiding this comment.
LGTM, thanks for doing this @fredrikekre! It is great to see this in a more organized form.
Any chance we could also have some unit tests for this now that it is split up a bit more? I might be good to test should_deploy in a few withenvs.
fredrikekre
force-pushed
the
fe/gh-actions
branch
from
9fd675e
to
15397f3
Compare
fredrikekre
changed the title
|
Pushed the interface for GH Actions here now. |
fredrikekre
force-pushed
the
fe/gh-actions
branch
from
15397f3
to
cc6604a
Compare
fredrikekre
force-pushed
the
fe/gh-actions
branch
from
cc6604a
to
ef7c3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will clean up, and maybe split into more PRs, but it works: https://github.com/fredrikekre/Literate.jl/runs/247983206