Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for other language in HTML tag #1223

Merged
merged 4 commits into from
Jan 17, 2020
Merged

add support for other language in HTML tag #1223

merged 4 commits into from
Jan 17, 2020

Conversation

Roger-luo
Copy link
Contributor

@Roger-luo Roger-luo commented Jan 6, 2020 •
edited by mortenpi
Loading

This should partly address #977

@mortenpi mortenpi added Format: HTML Related to the default HTML output Type: Enhancement labels Jan 6, 2020
@mortenpi mortenpi added this to the 0.24.4 milestone Jan 6, 2020
mortenpi
mortenpi approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Could you also drop a small note about this into the CHANGELOG?

@mortenpi mortenpi merged commit c55fad1 into JuliaDocs:master Jan 17, 2020
@Roger-luo
Copy link
Contributor Author

oh sorry I was in vacation didn't see it. thanks tho!

@nil-is-lin
Copy link

This is a very useful feature. However, I found I don't know how to use it. It will be more perfect if you could add examples to the documentation.

@mortenpi mortenpi mentioned this pull request Aug 18, 2020
Merged
@mortenpi
Copy link
Member

@nil-is-lin It is documented in the docstring of HTML. I updated it in #1407 to make it slightly more precise, but feel free to comment there or open a PR if you think it could be further clarified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortenpi mortenpi mortenpi approved these changes

Assignees
No one assigned
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Milestone
0.24.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Roger-luo @nil-is-lin @mortenpi