Generalize strict

[ericphanson]

Fixes #1686 by generalizing strict to accept a symbol or vector of symbols. I was going to do just doctest but looking at it, it seemed about as easy to do all of them.

I only found tests with strict for doctests though, but I modified those to try some of the new versions.

[ericphanson]

What this does:

• collects all the names we use for errors and puts them in ERROR_NAMES
• allows strict to be set to a Bool as now, or a Symbol from ERROR_NAMES or a Vector{Symbol} that is a subset of ERROR_NAMES. This allows any middle ground between false and true, by being strict about any subset of the possible errors. This is validated by is_strict_kw, a new utility function.
• Sets the loglevel when we log errors according to if we are being strict about that error or not, using is_strict, a new utility function
• Errors at the end of the build if we are strict about any errors that have occurred (or after doctest time if we are strict about doctest and any doctests have failed), using is_strict
• Adds some unit tests for is_strict and is_strict_kw, and runs some of the doctest tests with various equivalent (for the purpose of doctests) choices of strict.

I am happy with it from my end and am ready for review when you get a chance.

[ericphanson]

Bump

[ericphanson]

Bump

[fredrikekre]

LGTM but would be good to document somewhere what the different options for symbols are.

[ericphanson]

The list is in the docstring (https://github.com/JuliaDocs/Documenter.jl/pull/1689/files#diff-2c620811ba00ffd5e7b818bdefbab47fe9d7e3e11d046e6fe18e5c01fdff3f0cR227) but maybe you’re saying the meaning of them all should be documented too? That would make sense to me, though I’m not sure where to put it.

[ericphanson]

CI failures seem to be pkg server issues. (Especially considering everything passed just before and the only difference was typos in a docstring).

[ericphanson]

Bump :). Would love to get this in soon-- I think it would massively increase the usability of doctests if there was an easy way to make them fail the built without also making everything else fatal.

[ericphanson]

Bump

[ericphanson]

awesome, thanks @fredrikekre!