-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix outdated GitHub Docs links #1796
Conversation
The period at the end usually gets interpreted as part of the URL in browsers, making it impossible to click on the links or copy the link address.
I believe the 403s that linkcheck complains about are an issue on GitHub's end, as I am also seeing them locally (intermittently) along with some 503s. I would not merge this PR until linkcheck actually passes. |
It actually starts looking like the 403s on
vs. when you spoof a browser UA:
To work around this, I changed linkcheck to spoof a realistic browser UA (somewhat arbitrarily picking the example Chrome UA from Mozilla docs), which makes linkcheck pass again with the I considered having the spoofed UA be a fallback, if the initial linkcheck fails, but the complexity is probably not worth it. This does mean that theoretically it's possible that some linkchecks will now fail because the servers will consider this UA to be suspicious or something along those lines. But I think it should mostly have the opposite effect --- any server that cares about the UA on this level will hopefully consider this UA to be more trustworthy. |
They have been throwing 301s. Should hopefully fix linkcheck.