Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI job to verify CHANGELOG #1800

Merged
merged 6 commits into from
May 2, 2022
Merged

Add a CI job to verify CHANGELOG #1800

merged 6 commits into from
May 2, 2022

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Apr 19, 2022

Following up on #1787. This should catch various errors (missings links etc.) that get introduced into the CHANGELOG sometimes.

It depends on an experimental branch of CommonMark.jl, as CommonMark does not fully support reference links right now (MichaelHatherly/CommonMark.jl#40). Once those changes get into CommonMark, the code here should be updated and then the Manifest.toml can be removed.

@mortenpi
Copy link
Member Author

mortenpi commented May 2, 2022

I'll go ahead an merge this as it does work and so that we could get the benefits of this CI job, even though the changes in CommonMark need some more work.

@mortenpi mortenpi merged commit d5b5763 into master May 2, 2022
@mortenpi mortenpi deleted the mp/check-changelog branch May 2, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant